Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file/folder name auto-completion in q chat #930

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

kkashilk
Copy link
Collaborator

@kkashilk kkashilk commented Mar 25, 2025

Issue #, if available:

  1. File/Folder name auto-complete does not currently work in the q-chat window

Description of changes:

Extended the ChatCompleter to suggest file/folder name auto-completions as fallback

Tested by running -
cargo run --bin q_cli -- chat

See screenshot below for info on what the output looks like -

Screenshot 2025-03-24 at 11 11 29 PM

@kkashilk kkashilk requested a review from a team as a code owner March 25, 2025 02:46
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.

Project coverage is 13.79%. Comparing base (151873d) to head (0c9ce16).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/q_cli/src/cli/chat/prompt.rs 94.93% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
+ Coverage   13.74%   13.79%   +0.04%     
==========================================
  Files        2360     2360              
  Lines      204441   204539      +98     
  Branches   184805   184903      +98     
==========================================
+ Hits        28109    28221     +112     
+ Misses     174840   174823      -17     
- Partials     1492     1495       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kkashilk kkashilk force-pushed the filename-autocomplete branch from dc63bee to 35e3f2b Compare March 25, 2025 02:52
Implement PathCompleter struct to provide filesystem path completion
functionality in the CLI, enhancing the user experience with
intelligent path suggestions during input.

🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)
Copy link
Collaborator

@mr-lee mr-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - just fix the tests and formatter and we can merge!

@kkashilk kkashilk force-pushed the filename-autocomplete branch from 42057df to 0c9ce16 Compare March 26, 2025 04:22
@mr-lee mr-lee merged commit 447c3ff into aws:main Mar 26, 2025
10 checks passed
@kkashilk kkashilk deleted the filename-autocomplete branch March 26, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants