Skip to content

Commit

Permalink
Moves decision transition ahead in acceptance handler to avoid null p…
Browse files Browse the repository at this point in the history
…ointer exception in caret movement listener
  • Loading branch information
dingfeli committed Sep 26, 2024
1 parent ae140be commit ba40253
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public final boolean isEnabled() {
public final Object execute(final ExecutionEvent event) throws ExecutionException {
var suggestion = QInvocationSession.getInstance().getCurrentSuggestion();
var widget = QInvocationSession.getInstance().getViewer().getTextWidget();
QInvocationSession.getInstance().transitionToDecisionMade();
Display display = widget.getDisplay();
display.syncExec(() -> this.insertSuggestion(suggestion.getInsertText()));
return null;
Expand All @@ -36,7 +37,6 @@ private void insertSuggestion(final String suggestion) {
var insertOffset = widget.getCaretOffset();
doc.replace(insertOffset, 0, suggestion);
widget.setCaretOffset(insertOffset + suggestion.length());
QInvocationSession.getInstance().transitionToDecisionMade();
QInvocationSession.getInstance().getViewer().getTextWidget().redraw();
QInvocationSession.getInstance().executeCallbackForCodeReference();
QInvocationSession.getInstance().end();
Expand Down

0 comments on commit ba40253

Please sign in to comment.