Refactoring

aws · Sep 30, 2024 · f5a8163 · f5a8163
1 parent cc0e02d
commit f5a8163
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 24 deletions.
diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/AmazonQLspClientImpl.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/AmazonQLspClientImpl.java
@@ -31,8 +31,10 @@ public final CompletableFuture<ConnectionMetadata> getConnectionMetadata() {
     }
 
     @Override
-    public CompletableFuture<List<Object>> configuration(ConfigurationParams configurationParams) {
-        if (configurationParams.getItems().size() == 0) return CompletableFuture.completedFuture(null);
+    public final CompletableFuture<List<Object>> configuration(final ConfigurationParams configurationParams) {
+        if (configurationParams.getItems().size() == 0) {
+            return CompletableFuture.completedFuture(null);
+        }
         List<Object> output = new ArrayList<>();
         configurationParams.getItems().forEach(item -> {
             if (item.getSection().equals(Constants.LSP_CONFIGURATION_KEY)) {

diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/util/Constants.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/util/Constants.java
@@ -4,10 +4,10 @@
 package software.aws.toolkits.eclipse.amazonq.util;
 
 public final class Constants {
-	
-	private Constants() {
-		// to avoid initiation
-	}
+
+    private Constants() {
+        // to avoid initiation
+    }
 
     public static final String CUSTOMIZATION_STORAGE_INTERNAL_KEY = "aws.q.customization.eclipse";
     public static final String LSP_CUSTOMIZATION_CONFIGURATION_KEY = "customization";

diff --git a/plugin/src/software/aws/toolkits/eclipse/amazonq/views/CustomizationDialog.java b/plugin/src/software/aws/toolkits/eclipse/amazonq/views/CustomizationDialog.java
@@ -115,14 +115,14 @@ protected void createButtonsForButtonBar(final Composite parent) {
     protected void okPressed() {
         PluginLogger.info(String.format("Select pressed with responseSelection:%s and selectedArn:%s", this.responseSelection, this.selectedCustomisationArn));
         if (this.responseSelection.equals(ResponseSelection.AMAZON_Q_FOUNDATION_DEFAULT)) {
-        	PluginStore.remove(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY);
+            PluginStore.remove(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY);
         } else {
-        	PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
-        	Map<String, Object> updatedSettings = new HashMap<>();
-        	Map<String, String> internalMap = new HashMap<>();
-        	internalMap.put(Constants.LSP_CUSTOMIZATION_CONFIGURATION_KEY, this.selectedCustomisationArn);
-        	updatedSettings.put(Constants.LSP_CONFIGURATION_KEY, internalMap);
-        	ThreadingUtils.executeAsyncTask( () -> CustomizationUtil.triggerChangeConfigurationNotification(updatedSettings));
+            PluginStore.put(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY, this.selectedCustomisationArn);
+            Map<String, Object> updatedSettings = new HashMap<>();
+            Map<String, String> internalMap = new HashMap<>();
+            internalMap.put(Constants.LSP_CUSTOMIZATION_CONFIGURATION_KEY, this.selectedCustomisationArn);
+            updatedSettings.put(Constants.LSP_CONFIGURATION_KEY, internalMap);
+            ThreadingUtils.executeAsyncTask(() -> CustomizationUtil.triggerChangeConfigurationNotification(updatedSettings));
         }
         super.okPressed();
     }

diff --git a/...tware/aws/toolkits/eclipse/amazonq/views/actions/CustomizationDialogContributionItem.java b/...tware/aws/toolkits/eclipse/amazonq/views/actions/CustomizationDialogContributionItem.java
@@ -63,17 +63,17 @@ public void fill(final Menu menu, final int index) {
         menuItem.addSelectionListener(new SelectionAdapter() {
             @Override
             public void widgetSelected(final SelectionEvent e) {
-            	CustomizationDialog dialog = new CustomizationDialog(shell);
-            	// TODO: This mock will be replaced by an actual call to LSP
-            	dialog.setCustomisationResponse(getCustomizations());
-            	String storedCustomizationArn = PluginStore.get(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY);
-            	if (StringUtils.isBlank(storedCustomizationArn)) {
-                	dialog.setResponseSelection(ResponseSelection.AMAZON_Q_FOUNDATION_DEFAULT);
-                	dialog.setSelectedCustomizationArn(null);
-            	} else {
-            		dialog.setResponseSelection(ResponseSelection.CUSTOMIZATION);
-            		dialog.setSelectedCustomizationArn(storedCustomizationArn);
-            	}
+                CustomizationDialog dialog = new CustomizationDialog(shell);
+                // TODO: This mock will be replaced by an actual call to LSP
+                dialog.setCustomisationResponse(getCustomizations());
+                String storedCustomizationArn = PluginStore.get(Constants.CUSTOMIZATION_STORAGE_INTERNAL_KEY);
+                if (StringUtils.isBlank(storedCustomizationArn)) {
+                    dialog.setResponseSelection(ResponseSelection.AMAZON_Q_FOUNDATION_DEFAULT);
+                    dialog.setSelectedCustomizationArn(null);
+                } else {
+                    dialog.setResponseSelection(ResponseSelection.CUSTOMIZATION);
+                    dialog.setSelectedCustomizationArn(storedCustomizationArn);
+                }
                 dialog.open();
             }
         });