Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show automatically webview on first load of a plugin #12

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Show automatically webview on first load of a plugin #12

merged 10 commits into from
Sep 17, 2024

Conversation

pras0131
Copy link
Contributor

  • Reference ticket: https://issues.amazon.com/issues/ECLIPSE-282
  • Show webview automatically upon first load of a plugin.
  • Saved the state in a persistent storage to track if the first load has already occurred before.
  • The code to load the initial webview is put inside workbench.getDisplay().asyncExec to ensure startup logic is executed on the correct UI thread, after the workbench has been initialized.

Testing

  • Tested the first load of a plugin to display automatically the webview.
  • Subsequent load does not open the webview itself.

@pras0131 pras0131 requested a review from breedloj September 13, 2024 15:07
breedloj
breedloj reviewed Sep 16, 2024
View reviewed changes
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/LspStartupActivity.java Outdated
@@ -33,6 +43,28 @@ protected IStatus run(final IProgressMonitor monitor) {
}
};
job.schedule();

if(PluginStore.get(ViewConstants.PREFERENCE_STORE_PLUGIN_FIRST_STARTUP_KEY) == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting - make sure to run Checkstyle on your changes

@pras0131 pras0131 requested a review from breedloj September 17, 2024 11:53
@breedloj breedloj merged commit b74d7cf into main Sep 17, 2024
1 check passed
@breedloj breedloj deleted the paras/showWebViewOnStartup branch September 17, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedloj breedloj breedloj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pras0131 @breedloj @jpinkney-aws