Pass client information to LSPs for user agent #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Change to include details about the Eclipse plugin as part of the LSP
InitializeRequestthat is sent down to LSPs during the initial handshake. This will be used by FLARE based LSP components to populate the user agent included in calls to AWS APIs.Example UA after this change:
AWS-Language-Servers AWS-CodeWhisperer/0.1.0 amazon-q-eclipse/0.0.1.snapshotChange also cleans up the plugin name and version and includes refactoring of both LSP connection providers over a common base class.
This change also migrates away from a hardcoded, Mac specific
nodeexecutable location for the Auth component, instead using the version which is retrieved by the Q FLARE artifact. This will be necessary for non Mac development, though in the long term it is expected that these two components will merge or have their own Node distributable.Finally, this change fixes a number of Checkstyle errors that had slipped in to the codebase.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.