Notifications helper to show notifications #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedloj
reviewed
Sep 19, 2024
Comment on lines
54
to
56
| if (this.notificationType.equals(NotificationType.CUSTOMIZATION_CHANGED)) { | ||
| showStandardNotification(parent); | ||
| } |
There was a problem hiding this comment.
Let's try to avoid this tight coupling to a specific NotificationType. If we anticipate multiple notification types we can subclass those off a base ToolkitNotification type. Granular text (e.g. for the customization message) should be passed in at time of use.
There was a problem hiding this comment.
got it, then i'll also rename NotificationHelper as ToolkitNotification then and remove the NotificationType enum.
breedloj
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference ticket: https://issues.amazon.com/issues/ECLIPSE-293
The PR aims to create a common place to get the notifications displayed on some plugin actions. One of the first use cases where notifications will be required is the Customization use case, where we display a notification to the user once the selection of the customization is performed. The current PR does not aim at integrating this code with the logic where we wish to display the same (that will be done when the logic is implemented)
However, for local testing - this is how i used the newly created notification helper functionality.
final String message = "Amazon Q inline suggestions are now coming from the Amazon-Internal-V1 customization"; AbstractNotificationPopup notification = new NotificationHelper(Display.getCurrent(), "Amazon Q Customization", message, NotificationType.CUSTOMIZATION_CHANGED); notification.open();Attaching a screenshot for the same: