Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label spacing theme issue in header and link foreground color issue in dark mode #279

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

taldekar
Copy link
Contributor

@taldekar taldekar commented Nov 27, 2024

Description of changes:

  • The feedback dialog header has a spacing problem where the link labels and the text labels don't have spaces between them on windows. Fixed this issue by adding a custom space between labels for different platforms.
  • The optional text was updated to be light gray.
  • The optional label is too close to the border. A grid margin was added inside the comment box that improves spacing inside the comment box.
  • The links do not have the right foreground color in dark mode. Fixed this issue by using the Link widget instead of Label.

Screenshots

  • Windows:
image
  • MacOS:
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@taldekar taldekar requested a review from breedloj November 27, 2024 22:04
@taldekar taldekar force-pushed the taldekar/FeedbackDialogThemeFix branch 2 times, most recently from 7695d6a to cd132a5 Compare November 29, 2024 18:16
@taldekar taldekar force-pushed the taldekar/FeedbackDialogThemeFix branch from cd132a5 to bbcae5d Compare December 4, 2024 21:14
@breedloj breedloj merged commit 94a74e0 into main Dec 10, 2024
1 check passed
@breedloj breedloj deleted the taldekar/FeedbackDialogThemeFix branch December 10, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants