Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds code reference view #29

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Adds code reference view #29

merged 10 commits into from
Sep 25, 2024

Conversation

dingfeli
Copy link
Contributor

Premise

Adds code reference view.
In order to facilitate the testing of this change, responses from the lsp servers were mocked. They have been artificially added with reference.

Description of changes:

  • Addition of a ViewPart
  • Modification of suggestion item ingestion (previously only insert text was extracted from these items, now we collect the entire InlineCompletionItem
  • Data schema change on InlineCompletionItem to accommodate for the extra fields needed to extra reference information

Test

ezgif-5-15ee29fc24

(The overlapping ghost text with user buffer is an issue that I shall fix in a later PR).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dingfeli dingfeli requested a review from breedloj September 20, 2024 01:01
this.references = references;
}

public class Reference {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep each class in its own file

@dingfeli dingfeli merged commit f17c365 into main Sep 25, 2024
1 check passed
@dingfeli dingfeli deleted the code-reference branch September 25, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants