Fix chat streaming bug #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedloj
approved these changes
Dec 5, 2024
shruti0085
reviewed
Dec 6, 2024
| @@ -148,8 +149,7 @@ private ChatRequestParams addEditorState(final ChatRequestParams chatRequestPara | |||
| // only include files that are accessible via lsp which have absolute paths | |||
| getOpenFileUri().ifPresent(filePathUri -> { | |||
| chatRequestParams.setTextDocument(new TextDocumentIdentifier(filePathUri)); | |||
| getSelectionRangeCursorState() | |||
| .ifPresent(cursorState -> chatRequestParams.setCursorState(Arrays.asList(cursorState))); | |||
| getSelectionRangeCursorState().ifPresent(cursorState -> chatRequestParams.setCursorState(Arrays.asList(cursorState))); | |||
There was a problem hiding this comment.
please revert any formatting changes in this PR. That takes away time from reviewing the actual change
There was a problem hiding this comment.
Okay, will do. Sorry!
| chatUiRequestListener.onSendToChatUi(message); | ||
| } | ||
| String message = jsonHandler.serialize(command); | ||
| chatUiRequestListenerFuture.thenApply(listener -> { |
There was a problem hiding this comment.
this approach seems a lil odd IMO although correct. Traditionally listeners in an event subscriber pattern are not intended to be completable futures. In this case, the webview class is the listener to an event. Why do we need to return the listener on L248? Instead can we not make the event handling async i.e make the sendToChatUi call a completable Future insead?
There was a problem hiding this comment.
Let's address this as part of the larger refactor to the views @taldekar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #295
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.