Added test coverage for cleanup method #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedloj
approved these changes
Dec 17, 2024
nborges-aws
force-pushed
the
nickdb/lspFetcherCleanupTest
branch
2 times, most recently
from
f1d85bf to
1c008ad
Compare
nborges-aws
force-pushed
the
nickdb/lspFetcherCleanupTest
branch
from
1c008ad to
4788ba8
Compare
taldekar
pushed a commit
that referenced
this pull request
Jan 27, 2025
taldekar
added a commit
that referenced
this pull request
Jan 27, 2025
* Add event bus * Integrate event bus * Remove auth status change listener and provider * Fix indentation in pom * Fix pom.xml indentation * Remove singleton implementation and add null check to post method * Move EventBroker access to Activator * Update event broker calls to go through Activator * Fix bug caused by null EventBroker most likely because Activator hasn't been intitialized yet * Fix bug caused by null EventBroker most likely because Activator hasn't been intitialized yet * Add event bus * Remove subscription and type introspection * Fix artifact versioning bug * Added test coverage for cleanup method (#310) * Add tests for EventBroker component * Delete accidental RemoteLspFetcherTest addition * Revert "Delete accidental RemoteLspFetcherTest addition" This reverts commit 15ae75a. * Remove implicit deduplication --------- Co-authored-by: Nicolas <[email protected]> Co-authored-by: Jonathan Breedlove <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Addition of unit tests for cleanup methods added in PR-213.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.