Event Bus in Native Java #324
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package software.aws.toolkits.eclipse.amazonq.events; | ||
|
|
||
| public final class TestEvent { | ||
| private final String message; | ||
| private final int sequenceNumber; | ||
|
|
||
| public TestEvent(final String message, final int sequenceNumber) { | ||
| this.message = message; | ||
| this.sequenceNumber = sequenceNumber; | ||
| } | ||
|
|
||
| public String getMessage() { | ||
| return message; | ||
| } | ||
|
|
||
| public int getSequenceNumber() { | ||
| return sequenceNumber; | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package software.aws.toolkits.eclipse.amazonq.observers; | ||
|
|
||
| import java.lang.reflect.ParameterizedType; | ||
| import java.lang.reflect.Type; | ||
|
|
||
| public interface EventObserver<T> { | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| default Class<T> getEventType() { | ||
| Class<?> currentClass = getClass(); | ||
| while (currentClass != null) { | ||
| for (Type type : currentClass.getGenericInterfaces()) { | ||
| if (type instanceof ParameterizedType paramType && (paramType.getRawType() == EventObserver.class)) { | ||
| Type typeArg = paramType.getActualTypeArguments()[0]; | ||
| if (typeArg instanceof Class<?>) { | ||
| return (Class<T>) typeArg; | ||
| } | ||
| throw new IllegalStateException("Generic type parameter is not a Class"); | ||
| } | ||
| } | ||
| currentClass = currentClass.getSuperclass(); | ||
| } | ||
| throw new IllegalStateException("Could not determine generic type"); | ||
| } | ||
|
|
||
| void onEvent(T event); | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package software.aws.toolkits.eclipse.amazonq.observers; | ||
|
|
||
| import java.lang.reflect.ParameterizedType; | ||
| import java.lang.reflect.Type; | ||
|
|
||
| public interface StreamObserver<T> extends EventObserver<T> { | ||
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") | ||
| default Class<T> getEventType() { | ||
|
There was a problem hiding this comment. What is the difference between StreamObserver and EventObserver? I see a few new functions in this class but the getEventType looks the same There was a problem hiding this comment. The EventObserver is the base bones version of a subscriber that only cares about events on the data channel. The StreamObserver extends this functionality with hooks for when the stream errors out or completes. The interfaces were introduced because the standard subscriber method |
||
| Class<?> currentClass = getClass(); | ||
| while (currentClass != null) { | ||
| for (Type type : currentClass.getGenericInterfaces()) { | ||
| if (type instanceof ParameterizedType paramType && (paramType.getRawType() == StreamObserver.class)) { | ||
| Type typeArg = paramType.getActualTypeArguments()[0]; | ||
| if (typeArg instanceof Class<?>) { | ||
| return (Class<T>) typeArg; | ||
| } | ||
| throw new IllegalStateException("Generic type parameter is not a Class"); | ||
| } | ||
| } | ||
| currentClass = currentClass.getSuperclass(); | ||
| } | ||
| throw new IllegalStateException("Could not determine generic type"); | ||
| } | ||
|
|
||
| void onError(Throwable error); | ||
| void onComplete(); | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package software.aws.toolkits.eclipse.amazonq.publishers; | ||
|
|
||
| import software.aws.toolkits.eclipse.amazonq.broker.EventBroker; | ||
| import software.aws.toolkits.eclipse.amazonq.events.TestEvent; | ||
|
|
||
| public final class TestPublisher { | ||
|
|
||
| public TestPublisher() { | ||
| Thread publisherThread = new Thread(() -> { | ||
|
There was a problem hiding this comment. Can we not map this to the auth events that get posted? There was a problem hiding this comment. We have separate publishers for auth events. This was just to demo that the event bus was performant and could deliver events in the order they were posted. |
||
| try { | ||
| Thread.sleep(5000); | ||
| EventBroker eventBroker = EventBroker.getInstance(); | ||
|
|
||
| for (int i = 0; i < 100000; i++) { | ||
| eventBroker.post(new TestEvent("Test Event " + i, i)); | ||
| } | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| } | ||
| }, "TestPublisher-Thread"); | ||
|
|
||
| publisherThread.start(); | ||
| } | ||
|
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package software.aws.toolkits.eclipse.amazonq.subscriber; | ||
|
|
||
| import software.aws.toolkits.eclipse.amazonq.events.TestEvent; | ||
| import software.aws.toolkits.eclipse.amazonq.observers.EventObserver; | ||
| import software.aws.toolkits.eclipse.amazonq.plugin.Activator; | ||
|
|
||
| public final class TestSubscribers implements EventObserver<TestEvent> { | ||
|
|
||
| private int previousSequenceNumber = -1; | ||
|
|
||
| public TestSubscribers() { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void onEvent(final TestEvent event) { | ||
| // Activator.getLogger().info(event.getMessage()); | ||
|
|
||
| if (event.getSequenceNumber() - previousSequenceNumber != 1) { | ||
|
There was a problem hiding this comment. I am unclear on the significance of the sequence number here There was a problem hiding this comment. The sequence numbers are more for testing the POC on my end. They helped ensure that the events arrived in the order in which they were published to all subscribers. |
||
| Activator.getLogger().info("OUT OF ORDER: " + event.getSequenceNumber() + " " + previousSequenceNumber); | ||
| } | ||
|
|
||
| previousSequenceNumber = event.getSequenceNumber(); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any references that you took inspiration from to compose this class? If yes, those would be useful to link in the description here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I used stack overflow for this, but it wasn't exactly this. I can try to find it. It think it was this one: https://stackoverflow.com/questions/3437897/how-do-i-get-a-class-instance-of-generic-type-t. I'll add it to the code.