Introduce RxJava-based Event Bus #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedloj
reviewed
Jan 24, 2025
plugin/src/software/aws/toolkits/eclipse/amazonq/broker/EventBroker.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/broker/api/EventObserver.java
Show resolved
Hide resolved
…'t been intitialized yet
…'t been intitialized yet
|
Looks good! Do you plan to add tests for the event broker? |
Yup, I'll add them now! |
breedloj
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #322
Description of changes:
This PR introduces an Event Bus implementation using RxJava. The Event Bus is hosted in the EventBroker class, which provides methods to post and subscribe to events of arbitrary type. Two new interfaces were introduced as part of the Brokers API, since the original implementations weren't explicitly designed for an Event Bus use-case and didn't make their function clear to the programmer. The first is an EventObserver which is the primary method of subscribing to events by overriding the
onEvent(event)method. The other interface is Subscription which is returned when Subscribing to an new event stream and provides a methodcancel()to cancel the subscription. The subscriber callbacks are all handled by a separate scheduler, so the publishing thread isn't blocked.The EventBroker has also been integrated into the code base and replaces the AuthStatusChangedListener.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.