Handle invalid proxy URLs #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedloj
force-pushed
the
breedloj/proxyUrl
branch
from
55b468c to
713842a
Compare
shruti0085
approved these changes
Jan 27, 2025
| } | ||
| } catch (IllegalArgumentException e) { | ||
| if (!hasSeenInvalidProxyNotification) { | ||
| hasSeenInvalidProxyNotification = true; |
There was a problem hiding this comment.
If a user sees this the first time, closes the display. Goes back and changes the proxy url but still does fix the format correctly, will they not see this popup then?
There was a problem hiding this comment.
It's a good point. We don't currently evaluate or attempt to use the proxy URL until the IDE is restarted. This is an overall area for improvement - ideally we can hot swap to the new setting without the need for a restart. The current logic works within our existing constraints. Input validation would also help address this. I'll create a backlog item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Validates that configured (via preference) or passed (via environment variable) proxy URLs are valid before using them. URLs are parsed for correctness and ignored if invalid. Additionally, a prompt is shown to the user.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.