Cleanup dead code in webviews #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruti0085
approved these changes
Sep 24, 2024
| @Override | ||
| protected final void handleAuthStatusChange(final boolean isLoggedIn) { | ||
| var browser = super.getBrowser(); |
There was a problem hiding this comment.
should be able to do getBrowser I believe similar to L33
angjordn
reviewed
Sep 25, 2024
| @@ -42,16 +30,13 @@ public AmazonQChatWebview() { | |||
| @Override | |||
| public final void createPartControl(final Composite parent) { | |||
| setupAmazonQView(parent, true); | |||
| browser = getBrowser(); | |||
| var browser = getBrowser(); | |||
There was a problem hiding this comment.
Should the variable type be Browser instead of var?
There was a problem hiding this comment.
Type inference is supported as of Java 10+ - another thing I would like to do consistently and add a check for if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We had a few leftover "goodies" in our views from the prototype days - specifically a handler for opening the preference window, selection changed, and a leftover JS file that isn't used. We also still had an LSP binary still checked in to the codebase. 😄
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.