Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable arrow keys if text area is empty #352

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Disable arrow keys if text area is empty #352

merged 7 commits into from
Feb 20, 2025

Conversation

taldekar
Copy link
Contributor

@taldekar taldekar commented Feb 5, 2025

Issue #348

Description of changes:

  • Added an event listener to check if text area is empty and block the propagation of arrow key events in mynah if no text exists that can be navigated.
  • This prevents unrecognized characters from being rendered in the chat.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@taldekar taldekar requested a review from breedloj February 5, 2025 20:36
@taldekar
Fix unrelated changes introduced by stash apply
58e74c6
@taldekar
Support select all and copy shortcuts in chat (#353)
cab750c 
* Support select all and copy keyboard shortcuts in chat

* Fix submitted code block cancel button (#354)

* Fix submitted code block cancel button

* Fix empty overflow bubble (#356)

* Fix empty pop-up when no overflow in follow up question text

* Fix accidentally removed copy event listener
@taldekar
Merge branch 'main' into taldekar/blockArrowKeysInChatPrompt
ceda64d
@taldekar
Fix checkstyle issues
4d9b341
@taldekar taldekar changed the base branch from main to feature/MynahUIFix February 17, 2025 17:33
breedloj
breedloj reviewed Feb 20, 2025
View reviewed changes
plugin/META-INF/MANIFEST.MF Outdated
Bundle-Classpath: target/classes/,
Bundle-Classpath: .,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this. It automatically updated I think.

@taldekar taldekar merged commit 6f760f1 into feature/MynahUIFix Feb 20, 2025
@taldekar taldekar deleted the taldekar/blockArrowKeysInChatPrompt branch February 20, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedloj breedloj breedloj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldekar @breedloj