-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat Partial Result #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingfeli
approved these changes
Sep 25, 2024
plugin/src/software/aws/toolkits/eclipse/amazonq/chat/ChatCommunicationManager.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/util/ProgressNotficationUtils.java
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/chat/ChatPartialResultMap.java
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/chat/ChatMessage.java
Outdated
Show resolved
Hide resolved
d1aece6
to
0a6fa79
Compare
breedloj
reviewed
Sep 26, 2024
plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQChatViewActionHandler.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/util/ProgressNotficationUtils.java
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/AmazonQLspClientImpl.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/util/JsonHandler.java
Outdated
Show resolved
Hide resolved
breedloj
approved these changes
Sep 27, 2024
cc60b9e
to
8e55f15
Compare
8e55f15
to
b1d1294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Detailed Flow
sendChatPrompt
message is received from Webview and handled byAmazonQChatViewActionHandler
AmazonQChatViewActionHandler
initiates a send via thechatCommunicationManager.sendMessageToChatServer
ChatMessageProvider
ChatMessageProvider
defines aChatMessage
and initiates thesendChatMessageWithProgress
methodpartialResultToken
toChatMessage
mapping maintained by theChatCommunicationManager
partialResultToken
(which is the indicator for the LSP server to intermittently send progress notifications to the client)AmazonQLspClientImpl.notifyProgress
. Once a progress notification is retrieved by the client, the ChatMessage is retrieved utilizing thepartialResultToken
contained in theProgressParams
of the notification. A message is sent to the Webview to display the partial chat result.partialResultToken
toChatMessage
mapping entry is removed and a message is sent to the Webview indicating that it is the final result.Demo
Shorted.Partial.Result.Demo.mov