Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor input listener for inline #37

Merged
merged 17 commits into from
Sep 27, 2024
Merged

Conversation

dingfeli
Copy link
Contributor

Premise

The existing typeahead logic leverages a single verifyKey listener to verify all user input keystrokes.
This makes it the logic very convoluted and hard to deal with edge cases.
A refactor to separate the listener into verifyKey + verifyText would help clean up the / simplify the logic.

Description of changes:
With this change, the following bugs were fixed:

  • Fix vertical indent not being on the right line when there are auto closing curly braces
  • Fix caret movement check becoming overly loose or stringent
  • Fix backspacing on typed brackets causing input listener to crash

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dingfeli dingfeli merged commit c9c782b into main Sep 27, 2024
1 check passed
@dingfeli dingfeli mentioned this pull request Oct 3, 2024
@breedloj breedloj deleted the refactor-input-listener-for-inline branch November 4, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants