Auto detection of proxy settings #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldekar
reviewed
Feb 17, 2025
| if (!StringUtils.isEmpty(prefValue)) { | ||
| httpsProxy = prefValue; | ||
| } | ||
| public static String getHttpsProxyUrlForEndpoint(final String endpointUrl) { |
There was a problem hiding this comment.
Does making this an Optional make sense? It would make it explicit to the user that the String could be null
taldekar
approved these changes
Feb 17, 2025
breedloj
force-pushed
the
breedloj/autoDetectProxy
branch
2 times, most recently
from
6a5edb8 to
377d74c
Compare
breedloj
force-pushed
the
breedloj/autoDetectProxy
branch
from
377d74c to
a029172
Compare
taldekar
added a commit
that referenced
this pull request
Feb 20, 2025
* Fix line height for chat input box * Auto detection of proxy settings (#372) --------- Co-authored-by: Ishan Taldekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#355
Description of changes:
Adds support for auto detecting proxy configuration from the operating environment. Proxy configuration set in the plugin preference pane will always take precedence, otherwise resolution will query (in order):
http_proxy,https_proxy)http.proxyHost,http.proxyPort, etc, as defined here)This change also fixes a potentially severe bug for the plugin's HTTP clients where providing a custom CA cert would eliminate any existing certificates in the trust store. The intention of this logic is to additively inject the provided CA cert to the store.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.