Deserialization support for AWS LSP extended InitializeResult #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruti0085
reviewed
Oct 2, 2024
|
|
||
| @Override | ||
| @SuppressWarnings("unchecked") | ||
| public final <T> TypeAdapter<T> create(final Gson gson, final TypeToken<T> type) { |
There was a problem hiding this comment.
I had everything in this PR ready in a branch except for this class. Thanks for looking into it!
shruti0085
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
AWS Flare LSPs extend the basic LSP
InitializeResultwith extended metadata, such as available chat commands. By default these additional properties are lost by LSP4j's deserialization logic. This change models the extended type and registers in a custom type adapter for GSON (LSP4j's deser library) to deserialize into the extended type and therefore surface the properties.Keep in mind that there may be additional properties that need to be modeled to the extended
InitializeResult, but I am illustrating the pattern for accessing the chat commands here.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.