Initialize login UI with state needed for IdC flow #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedloj
force-pushed
the
breedloj/idcLoginWiring
branch
from
8868cb9 to
8e527ea
Compare
pras0131
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Sends the expected prepareUi Javascript command to the login UI to enable the IdC login flow. This includes passing the supported OIDC regions list over to the UI. I am taking that from the SDK's supported regions list and parsing it to the expected format. I added an
onLoadcallback from the view to trigger the new call once the browser has actually loaded the page - otherwise it fires too early and fails.Some of the other state is effectively hardcoded for now and will need to be updated as needed for anything that ends up being dynamic.
I have also wired up the LOGIN_IDC command. This gets fired when the "Continue" button is pressed and should, following this change, be used to request an IdC login from the auth module.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.