feat: expose max allocatable IPs thru grpc server#3305
Closed
mselim00 wants to merge 1 commit intoaws:masterfrom
Closed
feat: expose max allocatable IPs thru grpc server#3305mselim00 wants to merge 1 commit intoaws:masterfrom
mselim00 wants to merge 1 commit intoaws:masterfrom
Conversation
mselim00
commented
Jun 5, 2025
mselim00
force-pushed
the
expose-ip-count
branch
from
9f781a2 to
b4376af
Compare
jaydeokar
reviewed
Jun 18, 2025
mselim00
force-pushed
the
expose-ip-count
branch
from
b4376af to
896f4a4
Compare
Collaborator
|
@mselim00 can you rebase the changes and fix the conflicts ? |
mselim00
force-pushed
the
expose-ip-count
branch
3 times, most recently
from
79ec69b to
d21d9dd
Compare
mselim00
force-pushed
the
expose-ip-count
branch
from
d21d9dd to
09ef555
Compare
Contributor
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
Author
|
We went a different direction with this one, so this is no longer needed. See awslabs/amazon-eks-ami#2446 for reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix?:
N/A
What does this PR do / Why do we need it?:
Exposes the maximum number of IP addresses that IPAMD believes can be allocated in its current environment, given the applied VPC CNI configurations.
Testing done on this change:
Deployed this to my own cluster and wrote a simple application to make the GetMaxAllocatableIPs request to the GRPC server.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.