feat: enhanced subnet discovery rebase from #3380#3463
Merged
haouc merged 22 commits intoaws:masterfrom Feb 18, 2026
Merged
Conversation
haouc
force-pushed
the
shehbaj/enhanced-subnet-discovery-rebase
branch
from
04dfa96 to
ed16c61
Compare
Contributor
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
haouc
force-pushed
the
shehbaj/enhanced-subnet-discovery-rebase
branch
2 times, most recently
from
b42d116 to
e105464
Compare
haouc
force-pushed
the
shehbaj/enhanced-subnet-discovery-rebase
branch
4 times, most recently
from
1bf9f7a to
c4cef04
Compare
Contributor
Pavani-Panakanti
left a comment
Pavani-Panakanti
left a comment
There was a problem hiding this comment.
What is the rollback behavior to previous versions which won't have this feature ?
- Will there be any leaked ENI's that were created in secondary subnets as older version of CNI will not be aware of these ?
- Will there be any leaked pod ips which were assigned from secondary subnet ENI's ?
haouc
force-pushed
the
shehbaj/enhanced-subnet-discovery-rebase
branch
from
c4cef04 to
1ba4da9
Compare
Contributor
Author
New ENIs have the same tags as today's ENIs and will be cleaned up by sweepers in case of leaking. Rollback will need downgrading the version and recycle nodes. |
haouc
force-pushed
the
shehbaj/enhanced-subnet-discovery-rebase
branch
2 times, most recently
from
66bdcad to
73a0b46
Compare
Contributor
|
Added a comment, rest of the changes looks good to me |
Contributor
|
can you also refer to this code coverage report https://app.codecov.io/github/aws/amazon-vpc-cni-k8s/pull/3463. I think in awsutils.go there many missed lines. If you have added them do consider adding unit test to them. Lets make sure we atleast cover critical or tricky parts. |
haouc
force-pushed
the
shehbaj/enhanced-subnet-discovery-rebase
branch
3 times, most recently
from
76ef0ad to
b77ecd8
Compare
Contributor
|
Thanks Hao for the changes !! |
Pavani-Panakanti
approved these changes
Feb 17, 2026
haouc
force-pushed
the
shehbaj/enhanced-subnet-discovery-rebase
branch
from
b77ecd8 to
a8d36df
Compare
haouc
force-pushed
the
shehbaj/enhanced-subnet-discovery-rebase
branch
from
a8d36df to
8ef611f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix?:
What does this PR do / Why do we need it?:
The is a feature PR and rebased from #3380
Testing done on this change:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.