feat: add ConnectionTrackingSpec to ENIConfig#3618
Open
Sayrus wants to merge 1 commit intoaws:masterfrom
Open
Conversation
This change allows customizing timeout on ENI objects created by the VPC CNI. This allows changes such as reducing UDP Stream timeout which can be useful for cluster overwhelming security groups connection tracking. (e.g. clusters doing many DNS requests without node cache) Signed-off-by: Mathis Raguin <mathis.raguin@gitguardian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix?:
Implements #2677 (stale issue)
What does this PR do / Why do we need it?:
In 2023, AWS introduced configurable idle timeout. Reducing this timeout allows reducing conntrack usage.
This change allows customizing timeout on ENI objects created by the VPC CNI. This allows changes such as reducing UDP Stream timeout which can be useful for cluster overwhelming security groups connection tracking. (e.g. clusters doing many DNS requests without node cache)
Use-case: aws/karpenter-provider-aws#6826 (comment)
Testing done on this change:
Tested on a running EKS cluster to validate the previous behavior was unchanged (with and without prefix delegation, with and without UDP Idle timeouts set)
results in:

Will this PR introduce any new dependencies?:
No new external dependency.
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
Upgrading the CRD is backward compatible with running aws-node. Setting new ENIs parameters usually requires rotating the node.
Downgrading the CRD after changes were made to ENIConfig will make the added fields disappear, allowing safe downgrades. Parameters set on existing ENIs are not removed unless ENIs or nodes are rotated. This matches the behavior of the existing securityGroups / subnets parameters.
Tested on a small cluster.
Does this change require updates to the CNI daemonset config files to work?:
Changes required are in user-provided configuration files (ENIConfig). No parameters or modifications to the DaemonSet are required.
Does this PR introduce any user-facing change?: