Skip to content

Remove PE crds from helm charts#3625

Open
jaydeokar wants to merge 1 commit intoaws:masterfrom
jaydeokar:pe_fix
Open

Remove PE crds from helm charts#3625
jaydeokar wants to merge 1 commit intoaws:masterfrom
jaydeokar:pe_fix

Conversation

@jaydeokar
Copy link
Copy Markdown
Collaborator

@jaydeokar jaydeokar commented Mar 18, 2026

What type of PR is this?
cleanup

Which issue does this PR fix?: #3623

What does this PR do / Why do we need it?:
Removes the PE CRD since we install it via Control Plane and not Managed Addons. CRDs are present here for reference
https://github.com/aws/amazon-network-policy-controller-k8s/blob/main/charts/amazon-network-policy-controller-k8s/crds/crds.yaml

Testing done on this change: N/A. The CRD should come installed on an EKS cluster. For self managed clusters, customers have to install NPC to work together with NPA. If customers are not using NPA, they can disable it completely by setting --set nodeAgent.enabled=false

Will this PR introduce any new dependencies?: N/A

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
N/A

Does this change require updates to the CNI daemonset config files to work?: N/A

Does this PR introduce any user-facing change?: Yes refer to comment in testing section. The change only affects customers using self managed cluster and using VPC CNI

chore: Remove the references of PE CRD from helm chart as it is installed by control plane

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaydeokar jaydeokar requested a review from a team as a code owner March 18, 2026 00:51
@parlakisik
Copy link
Copy Markdown
Member

do we have any data about how many customer using self managed cluster with aws cni ?
they must upgrade the network policy controller. otherwise they will lose crd

Copilot AI review requested due to automatic review settings April 6, 2026 20:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the PolicyEndpoint CRD from the aws-vpc-cni Helm chart and the generated config/master manifests to avoid perpetual diffs (e.g., ArgoCD) now that EKS control plane installs the CRD.

Changes:

  • Dropped policyendpoints.networking.k8s.aws CRD from the Helm chart CRDs bundle.
  • Removed the same CRD from all config/master/aws-k8s-cni*.yaml rendered manifests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
config/master/aws-k8s-cni.yaml Removes embedded PolicyEndpoint CRD from rendered manifest.
config/master/aws-k8s-cni-cn.yaml Removes embedded PolicyEndpoint CRD from rendered manifest.
config/master/aws-k8s-cni-us-gov-east-1.yaml Removes embedded PolicyEndpoint CRD from rendered manifest.
config/master/aws-k8s-cni-us-gov-west-1.yaml Removes embedded PolicyEndpoint CRD from rendered manifest.
config/master/aws-k8s-cni-us-gov-west-1.yaml Removes embedded PolicyEndpoint CRD from rendered manifest.
charts/aws-vpc-cni/crds/customresourcedefinition.yaml Removes PolicyEndpoint CRD from chart CRDs so it’s no longer installed by Helm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 51 to 54
names:
plural: eniconfigs
singular: eniconfig
kind: ENIConfig
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the PolicyEndpoint CRD from the chart, which changes behavior for self-managed clusters that enable network policy (they will now need to install the NPC CRDs/controllers separately). The chart docs (e.g., charts/aws-vpc-cni/README.md) don’t currently mention this prerequisite—please add a note and link to the NPC CRDs/install instructions so Helm users don’t end up with a partially-working network policy setup.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants