Open
Conversation
Creates new .Values.fips value which sets AWS_USE_FIPS_ENDPOINT=true for each of the daemonset's containers. This configures the AWS SDK to use FIPS endpoints where regionally available.
There was a problem hiding this comment.
Pull request overview
Adds a Helm value to enable AWS SDK FIPS endpoints for the aws-vpc-cni DaemonSet, allowing users to opt into AWS_USE_FIPS_ENDPOINT=true where regional FIPS endpoints are available.
Changes:
- Introduces a new top-level Helm value
.Values.fips(defaultfalse). - Conditionally injects
AWS_USE_FIPS_ENDPOINT=trueinto the init container,aws-node, andaws-eks-nodeagentcontainers when.Values.fipsis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
charts/aws-vpc-cni/values.yaml |
Adds the new fips chart value and a brief description. |
charts/aws-vpc-cni/templates/daemonset.yaml |
Wires the new fips value into container env var injection across the DaemonSet containers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jaydeokar
reviewed
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
improvement
Which issue does this PR fix?:
What does this PR do / Why do we need it?:
Creates new .Values.fips value which sets AWS_USE_FIPS_ENDPOINT=true for each of the daemonset's containers. This configures the AWS SDK to use FIPS endpoints where regionally available.
Testing done on this change:
Tested in
us-east-1with FIPS builds of the chart's images.Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.