Open
Conversation
jaydeokar
reviewed
Apr 8, 2026
| } | ||
|
|
||
| // New will return aws.Config to be used by Service Clients. | ||
| func New(ctx context.Context) (aws.Config, error) { |
Collaborator
There was a problem hiding this comment.
Curious why not use this New() everwhere instead of defining in multiple places to get awscfg ?
Contributor
Author
There was a problem hiding this comment.
The reason is that each call site needs different config options beyond just the HTTP client timeout. Each
call site passes it via config.WithHTTPClient(awssession.NewAWSSDKHTTPClient()) alongside its own specific options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix?:
What does this PR do / Why do we need it?:
AWS SDK v2 defaults to no HTTP request timeout, which means API calls can hang indefinitely if AWS is unresponsive. Set a 10-second timeout on all SDK clients by configuring their clients.
Testing done on this change:
Tested in local clusters by replacing aws-node image.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.