Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fixes a missing change from PR #709
Which issue does this PR fix:
Fixes a missing change from PR #709
What does this PR do / Why do we need it:
In PR #709, the logic was updated to traverse all Parents in XXXRoute. However, some parts of the implementation were still only checking the first element (ParentRefs[0]), which was an unintended omission.
This PR fixes the logic to correctly traverse all Parents and ensures consistency with the intended behavior.
Additionally, some refactoring was performed to improve maintainability.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Verified that existing unit tests cover this change and all tests pass
Automation added to e2e:
None
Will this PR introduce any new dependencies?:
None
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
None
Does this PR introduce any user-facing change?:
Do all end-to-end tests successfully pass when running
make e2e-test
?:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.