feat(cli): support hotswap for AWS::BedrockAgentCore::Runtime #991
+1,521
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
5155ead to
f7ffdf2
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
f7ffdf2 to
b5410fb
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
b5410fb to
66a637d
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
66a637d to
2637f13
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
2637f13 to
6463a62
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
558db52 to
6463a62
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
6463a62 to
344769d
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
…e files"" This reverts commit 8b15d5a.
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
ba9a1e2 to
198f20a
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
04bbb7c to
234357a
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
hotswap-agentcore-runtime
branch
from
234357a to
6cdd150
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
…tswap-agentcore-runtime
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947
This PR adds hotswap support for
AWS::Bedrock::AgentRuntime.This feature can detect both of S3 code files and ECR images changes to deploy with hotswap.
Changes
@aws-sdk/client-bedrock-agentcore-controldependency3. Added yarnresolutionsto prevent ESM/CommonJS incompatibility (see the comment for details)4. Modifiedyarn-clingto support yarn resolutions field (see the comment for rationale)Note on 3 and 4: I chose this approach to resolve build failures after adding the Bedrock SDK, though I'm not certain it's the optimal solution. If there's a better approach, I'd welcome your feedback. See the commit "3904aab4" for details. FYI, I deleted the yarn.lock file and did a clean install again instead of resolutions, but I got the same error.Tried to revert the commit and modify the lock file manually, build succeeded.
To be specific, after installing
@aws-sdk/client-bedrock-agentcore-control, this change was automatically made. I then manually reverted everything except"@aws-sdk/client-bedrock-agentcore-control@^3":(since it was not directly related to that SDK). The build then succeeded.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license