-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(app-staging-synthesizer): cross-account support #26638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,6 +121,16 @@ export interface DefaultStagingStackOptions { | |
* @default 'StagingStack' | ||
*/ | ||
readonly stagingStackNamePrefix?: string; | ||
|
||
/** | ||
* Specify trusted principals for e.g. cross-account usage. | ||
* They will be added to the default principal. | ||
* Both file-role and image-role will be modified. | ||
* Will be ignored when custom roles are provided. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a validation for this please. |
||
* | ||
* @default - no additional principals will be trusted | ||
*/ | ||
readonly additionalTrustedPrincipals?: iam.IPrincipal[] | ||
} | ||
|
||
/** | ||
|
@@ -238,6 +248,8 @@ export class DefaultStagingStack extends Stack implements IStagingResources { | |
|
||
private readonly deployRoleArn?: string; | ||
|
||
private readonly additionalTrustedPrincipals: iam.IPrincipal[]; | ||
|
||
constructor(scope: App, id: string, private readonly props: DefaultStagingStackProps) { | ||
super(scope, id, { | ||
...props, | ||
|
@@ -263,6 +275,8 @@ export class DefaultStagingStack extends Stack implements IStagingResources { | |
this.providedFileRole = props.fileAssetPublishingRole?._specialize(specializer); | ||
this.providedImageRole = props.imageAssetPublishingRole?._specialize(specializer); | ||
this.stagingRepos = {}; | ||
|
||
this.additionalTrustedPrincipals = props.additionalTrustedPrincipals ?? []; | ||
} | ||
|
||
private validateAppId(id: string) { | ||
|
@@ -298,7 +312,10 @@ export class DefaultStagingStack extends Stack implements IStagingResources { | |
const roleName = this.fileRoleName; | ||
this.fileRole = new iam.Role(this, 'CdkFileRole', { | ||
roleName, | ||
assumedBy: new iam.AccountPrincipal(this.account), | ||
assumedBy: new iam.CompositePrincipal( | ||
new iam.AccountPrincipal(this.account), | ||
...this.additionalTrustedPrincipals, | ||
), | ||
}); | ||
|
||
this.fileRoleManifestArn = Stack.of(this).formatArn({ | ||
|
@@ -329,7 +346,10 @@ export class DefaultStagingStack extends Stack implements IStagingResources { | |
const roleName = this.imageRoleName; | ||
this.imageRole = new iam.Role(this, 'CdkImageRole', { | ||
roleName, | ||
assumedBy: new iam.AccountPrincipal(this.account), | ||
assumedBy: new iam.CompositePrincipal( | ||
new iam.AccountPrincipal(this.account), | ||
...this.additionalTrustedPrincipals, | ||
), | ||
}); | ||
this.imageRoleManifestArn = Stack.of(this).formatArn({ | ||
partition: '${AWS::Partition}', | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in assuming that this example is not complete?
Because by default this would assume a bootstrapped Deploy Role, and only the Deploy Role needs to be able to assume the Asset Roles.
So are you using
In practice when you need this feature (and the credentials happen to be for account
999999999999
?)