fix(s3): make SkipDestinationValidation undefined if not provided

[megarach0]

Issue # 31230

Closes #31230

Reason for this change

#30914 introduced default value for skipDestinationValidation that is set always to false (even if not provided). It should be undefined instead if not provided as this will affect custom resources.

Description of changes

• When skipDestinationValidation is not provided to the s3 bucket, leave it as undefined.
• Updated unit tests and integration tests.

Description of how you validated changes

• unit tests and integration tests added
• Also, not sure why some of the generated files are failing checks for the replace function when it escapes backslashes. I don't believe this is an actual issue, would like to get some eyes on that.

Checklist

• [ x ] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[megarach0]

Clarification Request: I have made changes to the integration test files and generated new snapshots. Confused why it's still requesting this.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (61626dc) to head (cfdfa33).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32361   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files         107      107           
  Lines        6996     6996           
  Branches     1290     1290           
=======================================
  Hits         5642     5642           
  Misses       1175     1175           
  Partials      179      179           

Flag	Coverage Δ
suite.unit	80.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	80.64% <ø> (ø)

[gracelu0]

Clarification Request: I have made changes to the integration test files and generated new snapshots. Confused why it's still requesting this.

I've added an exemption label to omit checking for integ test changes, I see that you've updated the snapshots. Thanks!

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[megarach0]

Clarification Request: I have made changes to the integration test files and generated new snapshots. Confused why it's still requesting this.

I've added an exemption label to omit checking for integ test changes, I see that you've updated the snapshots. Thanks!

Thank you! Do you know what my next steps are in getting this reviewed?

[megarach0]

Rebased.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 2a019f0
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[gracelu0]

Hi @megarach0 , I think we may need to make this change under a feature flag e.g. @aws-cdk/aws-s3:notificationsSkipDestinationValidationPropertyFalseDefault for the snapshot tests to pass. For new stacks the feature flag will be disabled so the value defaults to undefined and for existing stacks users can set the feature flag to keep the value as undefined. Let me know if that makes sense or if you need any further guidance. Thanks for working on this!

[megarach0]

Hi @megarach0 , I think we may need to make this change under a feature flag e.g. @aws-cdk/aws-s3:notificationsSkipDestinationValidationPropertyFalseDefault for the snapshot tests to pass. For new stacks the feature flag will be disabled so the value defaults to undefined and for existing stacks users can set the feature flag to keep the value as undefined. Let me know if that makes sense or if you need any further guidance. Thanks for working on this!

do you have an example PR where they needed to have a feature flag for the snapshot tests to pass. I'm kind of confused. My snapshot tests pass locally. I would imagine introducing this feature in the first place would've broken tests too then, but I don't believe I saw a feature flag for it. Thanks!

[megarach0]

I guess what am I doing differently versus what was done in #30916 that would warrant a feature flag and that one didn't.

[gracelu0]

#30418 introduced a feature flag for backwards compatibility so that existing projects don't have the custom resources updated again, but new projects will have undefined as the default. I'm not sure why the snapshot tests are passing locally but not in the PR build.. maybe try updating your branch and rerunning the integ tests? I assume you're already using the --update-on-failed flag to update?

[megarach0]

#30418 introduced a feature flag for backwards compatibility so that existing projects don't have the custom resources updated again, but new projects will have undefined as the default. I'm not sure why the snapshot tests are passing locally but not in the PR build.. maybe try updating your branch and rerunning the integ tests? I assume you're already using the --update-on-failed flag to update?

Thanks for the reply. I'll try rebasing, but yes I had to run the integration tests and had the --update-on-failed flag, otherwise I couldn't get the snapshot tests to pass. The snapshots changed and I added them to the commit, so I'm pretty confused as to why it's having issues now.