-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(custom-resource): provider framework lambda missing GetFunction permission #32904
base: main
Are you sure you want to change the base?
fix(custom-resource): provider framework lambda missing GetFunction permission #32904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32904 +/- ##
=======================================
Coverage 81.39% 81.39%
=======================================
Files 225 225
Lines 13714 13714
Branches 2411 2411
=======================================
Hits 11162 11162
Misses 2277 2277
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c5d517f
to
8a86bf8
Compare
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
014a862
to
d710a1a
Compare
525cbc9
to
4c475e9
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #26838.
Reason for this change
In the Provider Framework lambda code, there is a logic to catch error arise from invoking the User Defined handler lambda. Upon error, it polls the state of the User Defined handler until it is in ACTIVE state (#22612 added this logic):
aws-cdk/packages/aws-cdk-lib/custom-resources/lib/provider-framework/runtime/outbound.ts
Lines 66 to 80 in 64b865b
The polling uses the AWS SDK
waitUntilFunctionActiveV2
function, which calls the Lambda GetFunction API:https://github.com/aws/aws-sdk-js-v3/blob/6858c7e04730a2b524b06355969e4076c28ae863/clients/client-lambda/src/waiters/waitForFunctionActiveV2.ts#L57
However, the Provider Framework lambda does not have the
lambda:GetFunction
permission.Why is the issue saying the
lambda:GetFunctionConfiguration
is needed instead oflambda:GetFunction
?At some point in time, the retry logic used
waitUntilFunctionActive
for polling, which use theGetFunctionConfiguration
. But this is no longer the case after c3a4b7b#diff-85920270c638d83b082246e0026f1a316dd39aaa3cd8720fdaeb3d526e438f7fR66Description of changes
Added the
lambda:GetFunction
permission on the role used by the Provider Framework lambda.Describe any new or updated permissions being added
The
lambda:GetFunction
permission is added.Description of how you validated changes
There isn't a straight forward way to test the INACTIVE lambda scenario as one need to wait 14 days for a Lambda function to become INACTIVE. Therefore, I am not able to create an integ test.
What I did was locally changing the Provider Framework lambda code to throw an error such that it executes the catch block. Then I verified in CloudTrail that the Provider Framework lambda called
GetFunction
successfully and then it was also able to invoke the User Defined Handler lambda.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license