Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eks-v2): remove awsAuth #32961

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Jan 16, 2025

Reason for this change

For eks-v2 module, it uses API as authentication mode which means access entries will be used to replace aws-auth ConfigMap. awsAuth construct is not used anymore.

Description of changes

  • authenticationMode is removed from L2 because the only authentication mode allowed is API. The value is hardcode when creating the L1 resource.
  • Remove awsAuth and its usage in the new module

Description of how you validated changes

unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jan 16, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 16, 2025 01:41
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 16, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (35275c3) to head (7199ce4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32961   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files         226      226           
  Lines       13768    13768           
  Branches     2416     2416           
=======================================
  Hits        11219    11219           
  Misses       2271     2271           
  Partials      278      278           
Flag Coverage Δ
suite.unit 81.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.89% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7199ce4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants