-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codebuild): add new image types #32979
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
35f6153
to
6d756e2
Compare
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32979 +/- ##
=======================================
Coverage 81.48% 81.48%
=======================================
Files 226 226
Lines 13768 13768
Branches 2416 2416
=======================================
Hits 11219 11219
Misses 2271 2271
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me. However, I'd like to request to add an integration test to make sure the deployability. IMO, you can add a simple integ test file and use the imageType
property. Let me know if you need any help setting up the integ test file.
Issue # (if applicable)
Closes #32978.
Reason for this change
The CodeBuild CDK code needs to add new image types to match newly supported environment types:
LINUX_EC2
,ARM_EC2
andWINDOWS_EC2
.Description of changes
Add new image types
LINUX_EC2
,ARM_EC2
andWINDOWS_EC2
into file.Description of how you validated changes
Tests has been added. I ensured that the CDK was able to build, and that the output CloudFormation stack had the correct resources.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license