Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce the runtime of CLI unit tests by 2 minutes #32988

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 17, 2025

There was a test that was waiting a minute for some operation to time out after 7 retries.

Make those retries happen faster by hijacking the timer system.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

There was a test that was waiting a minute for some operation to time
out after 7 retries.

Make those retries happen faster by hijacking the timer system.
@rix0rrr rix0rrr requested a review from a team as a code owner January 17, 2025 13:04
@aws-cdk-automation aws-cdk-automation requested a review from a team January 17, 2025 13:04
@github-actions github-actions bot added the p2 label Jan 17, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (e31924a) to head (bbb0857).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32988   +/-   ##
=======================================
  Coverage   81.44%   81.44%           
=======================================
  Files         225      225           
  Lines       13750    13750           
  Branches     2412     2412           
=======================================
  Hits        11198    11198           
  Misses       2277     2277           
  Partials      275      275           
Flag Coverage Δ
suite.unit 81.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.80% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 17, 2025
Copy link
Contributor

mergify bot commented Jan 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 20, 2025
Copy link
Contributor

mergify bot commented Jan 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bbb0857
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c9d4a67 into main Jan 20, 2025
18 of 19 checks passed
@mergify mergify bot deleted the huijbers/improve-testing-speed branch January 20, 2025 15:08
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants