-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce the runtime of CLI unit tests by 2 minutes #32988
Conversation
There was a test that was waiting a minute for some operation to time out after 7 retries. Make those retries happen faster by hijacking the timer system.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32988 +/- ##
=======================================
Coverage 81.44% 81.44%
=======================================
Files 225 225
Lines 13750 13750
Branches 2412 2412
=======================================
Hits 11198 11198
Misses 2277 2277
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
There was a test that was waiting a minute for some operation to time out after 7 retries.
Make those retries happen faster by hijacking the timer system.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license