docs(rds): fix typos #33006
Open
docs(rds): fix typos #33006
+438
−292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
admired-contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33006 +/- ##
=======================================
Coverage 81.39% 81.39%
=======================================
Files 225 225
Lines 13714 13714
Branches 2411 2411
=======================================
Hits 11162 11162
Misses 2277 2277
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
suggested changes
Jan 18, 2025
| @@ -1355,7 +1355,7 @@ export class DatabaseInstanceReadReplica extends DatabaseInstanceNew implements | |||
| } | |||
|
|
|||
| // The read replica instance always uses the same engine as the source instance | |||
| // but some CF validations require the engine to be explicitely passed when some | |||
| // but some CF validations require the engine to be explicitly passed when some | |||
There was a problem hiding this comment.
Similar typo in security-group up for grab
There was a problem hiding this comment.
Single quotes is the preferred formatting style for the library and it should be used in the documentation for consistency. Can you please adjust?
aws-cdk-automation
removed
the
pr/needs-community-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None
Reason for this change
Fixed typos in code comments.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license