feat(servicecatalog): added property productType for CloudFormationProduct

[ymhiroki]

Reason for this change

This feature allows customers to create Service Catalog products of different types, such as CloudFormation templates, Terraform configurations, or external products.

Description of changes

• Added a new productType property to the CloudFormationProductProps interface
• Updated the CloudFormationProduct class to support the productType property
• Added a new test case to verify the ProductType configuration

These changes enable customers to specify the product type when creating a Service Catalog product with CloudFormationProduct.

Description of how you validated changes

The changes have been validated through the addition of a new unit test case and the integration test that verifies the ProductType configuration.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (e6f5bc8) to head (962e07e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33792   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103           

Flag	Coverage Δ
suite.unit	82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	∅ <ø> (∅)
packages/aws-cdk-lib/core	82.38% <ø> (ø)

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 962e07e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[badmintoncryer]

Thank you for your contribution! I have nothing to say about the implementation! I would like you to make some corrections to the documentation.

[badmintoncryer]

Could you please describe which type is set by default if undefined is passed?

When not explicitly setting the default value in CDK, it seems to be preferred by maintainers recently to explicitly describe what behavior occurs as the CloudFormation default, as shown below.

• https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-sns/lib/topic.ts#L109
• https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-cognito/lib/user-pool.ts#L468

You don't necessarily need to adhere to it, but you might receive such feedback from the maintainers.

[badmintoncryer]

How about explaining that it's possible to create Terraform and external products by configuring the productType?

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[aws-cdk-automation]

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

• Resume work on the PR
• OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
• OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.