Skip to content

feat(apigatewayv2): add dualstack support to domain name #34111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laurelmay
Copy link
Contributor

Reason for this change

This builds on #34054. Apparently for a domain name to have IPv4 and IPv6
support, the AWS::ApiGatewayV2::DomainName.DomainNameConfiguration also
needs to set IpAddressType. This is distinct from the settings on the
AWS::ApiGatewayV2::API itself.

Description of changes

This adds the ipAddressType property for DomainNameConfiguration.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Unit & Integration tests have been added. These are the first tests for DomainName
for HTTP APIs and leverage the tooling for custom domains in integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Apr 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 11, 2025 01:25
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Apr 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (74cbe27) to head (d3cffb1).
Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #34111   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         120      120           
  Lines        6976     6976           
  Branches     1178     1178           
=======================================
  Hits         5859     5859           
  Misses       1005     1005           
  Partials      112      112           
Flag Coverage Δ
suite.unit 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 83.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laurelmay laurelmay force-pushed the apigw-domain-name-dualstack branch from 1feb286 to fd50f44 Compare April 11, 2025 01:34
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 11, 2025 01:36

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@laurelmay laurelmay force-pushed the apigw-domain-name-dualstack branch 2 times, most recently from 0be752c to 529ce9b Compare April 11, 2025 12:38
@laurelmay laurelmay force-pushed the apigw-domain-name-dualstack branch from f2e2c40 to d3cffb1 Compare April 11, 2025 22:08
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d3cffb1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 11, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants