-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(apigatewayv2): add dualstack support to domain name #34111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34111 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 120 120
Lines 6976 6976
Branches 1178 1178
=======================================
Hits 5859 5859
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
1feb286
to
fd50f44
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
0be752c
to
529ce9b
Compare
f2e2c40
to
d3cffb1
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Reason for this change
This builds on #34054. Apparently for a domain name to have IPv4 and IPv6
support, the
AWS::ApiGatewayV2::DomainName.DomainNameConfiguration
alsoneeds to set
IpAddressType
. This is distinct from the settings on theAWS::ApiGatewayV2::API
itself.Description of changes
This adds the
ipAddressType
property forDomainNameConfiguration
.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Unit & Integration tests have been added. These are the first tests for
DomainName
for HTTP APIs and leverage the tooling for custom domains in integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license