fix(lambda): use nodejs22.x as default runtime #34117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecate NODE_LATEST in favor of determineLatestNodeRuntime(). - Fix misleading description of `@aws-cdk/aws-lambda-nodejs:useLatestRuntimeVersion` feature flag. - Mark nodejs18.x as deprecated (it's no longer in maintenance upstream, folks should upgrade) Nodejs18 is no longer in maintenance: https://nodejs.org/en/about/previous-releases and will be deprecated by AWS on 2025 September 1 https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html NODE_LATEST still points to v18: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-lambda/lib/runtime.ts#L119 I see that there's been an issue about this since 2023: aws#28125 The feature flag? `@aws-cdk/aws-lambda-nodejs:useLatestRuntimeVersion` https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-lambda-nodejs/lib/function.ts#L182 As written, gives you NODE_LATEST (v18) by default instead of v16. The best practice seems to be to use determineLatestNodeRuntime() https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-lambda/lib/runtime.ts#L414, But even that can default to v18.
github-actions
bot
added
valued-contributor
aws-cdk-automation
previously requested changes
Apr 11, 2025
github-actions
bot
added
bug
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Unsurprisingly, this changes snapshots for 11 "unrelated" test suites. Before I invest more time in this, I would like to get a commitment around having this merged. |
hye-click-up
approved these changes
Apr 14, 2025
|
We need this as our company need the latest support of nodejs |
|
This is very odd to use latest as a deprecated version? Can we move this to something that is representative of what the upstream nodejs project is listing as a usable version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aws-cdk/aws-lambda-nodejs:useLatestRuntimeVersionfeature flag.Nodejs18 is no longer in maintenance: https://nodejs.org/en/about/previous-releases
and will be deprecated by AWS on 2025 September 1 https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
NODE_LATEST still points to v18:
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-lambda/lib/runtime.ts#L119
I see that there's been an issue about this since 2023: #28125
The feature flag?
@aws-cdk/aws-lambda-nodejs:useLatestRuntimeVersionhttps://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-lambda-nodejs/lib/function.ts#L182
As written, gives you NODE_LATEST (v18) by default instead of v16.
The best practice seems to be to use determineLatestNodeRuntime()
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-lambda/lib/runtime.ts#L414,
But even that can default to v18.
Issue # (if applicable)
Closes #28125
Reason for this change
I just wasted a bunch of time assuming that NODEJS_LATEST meant what it implied.
More time assuming that "useLatestRuntimeVersion" did what it said.
Description of changes
See above.
Describe any new or updated permissions being added
None.
Description of how you validated changes
Existing tests updated with new defaults.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license