-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(apigateway): add mode
property for SpecRestApi
#34198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+454
−1,217
Merged
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8a90469
add mode property
tttol 5815043
add Enum
tttol 96812eb
add unit test&fix JSDoc
tttol 8547cda
update integ test
tttol 7f0055e
update README
tttol 08c6be3
Merge branch 'main' into add-restapiprops
tttol 6998dbd
update codecov.yml
tttol bdbf377
Revert "update codecov.yml"
tttol f25fd80
fix for the pr comment
tttol e7c9b0e
update integ.spec-restapi.ts
tttol 3c44a30
chore
tttol 086bd6a
rm empty line
tttol b210b75
Update packages/aws-cdk-lib/aws-apigateway/lib/restapi.ts
tttol 087fe89
Update packages/aws-cdk-lib/aws-apigateway/lib/restapi.ts
tttol de68b4f
Update packages/aws-cdk-lib/aws-apigateway/lib/restapi.ts
tttol 5ae6b9c
fix README
tttol 693dc96
Update packages/aws-cdk-lib/aws-apigateway/README.md
tttol 1a9b9e1
Merge branch 'main' into add-restapiprops
shikha372 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I noticed that the description should be below the following statement:
And it might be good to change the following sentence to be more natural... (Because the description is related to the above statements, or will be in conflict.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed. Added
However,
.