fix(route53): avoid setting unnecessary properties for Recovery Control type Route53 health check #34272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
repeat-contributor
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Apr 27, 2025
msysh
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #34262
Reason for this change
Unnecessary properties are set for Route53 health checks for Recovery Control type.
Description of changes
If HealthCheck type is Recovery Control, return
undefinedas default value for three properties (FailureThreshold,RequestInterval, andMeasureLatency).Describe any new or updated permissions being added
N/A
Description of how you validated changes
Used
Match.absent()to validate that the above three properties are not explicitly specified in existing unit tests. And added test cases to the integration testsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license