Skip to content

feat(route53-patterns): HttpsRedirect use Distribution as the default CloudFront distribution (under feature flag) #34312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(route53-patterns): HttpsRedirect use Distribution as the default CloudFront distribution (under feature flag) #34312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...nteg/test/aws-route53-patterns/test/integ.hosted-redirect-same-region.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions ...nteg.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 13 additions & 31 deletions ...eg.hosted-redirect-same-region.js.snapshot/integ-https-redirect-same-region.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
},
"redirectRedirectDistributionCFDistribution1A4C48E3": {
"redirectRedirectDistribution5423F951": {
"Type": "AWS::CloudFront::Distribution",
"Properties": {
"DistributionConfig": {
Expand All @@ -54,22 +54,9 @@
],
"Comment": "Redirect to aws.amazon.com from integ-same-region.example.com",
"DefaultCacheBehavior": {
"AllowedMethods": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts

Lines 1051 to 1053 in db62c5f

* @default AllowedMethods.ALLOW_GET_HEAD
*/
readonly allowedMethods?: AllowedMethods;

"GET",
"HEAD"
],
"CachedMethods": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts

Lines 1058 to 1060 in db62c5f

* @default CachedMethods.CACHE_GET_HEAD
*/
readonly cachedMethods?: CachedMethods;

"GET",
"HEAD"
],
"CachePolicyId": "658327ea-f89d-4fab-a63d-7e88639e58f6",
"Compress": true,
"ForwardedValues": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-defaultcachebehavior.html#cfn-cloudfront-distribution-defaultcachebehavior-forwardedvalues

Replaced by CachePolicyId

"Cookies": {
"Forward": "none"
},
"QueryString": false
},
"TargetOriginId": "origin1",
"TargetOriginId": "integhttpsredirectsameregionredirectRedirectDistributionOrigin1609D30F4",
"ViewerProtocolPolicy": "redirect-to-https"
},
"DefaultRootObject": "",
Expand All @@ -78,14 +65,8 @@
"IPV6Enabled": true,
"Origins": [
{
"ConnectionAttempts": 3,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/origin.ts

Lines 91 to 93 in db62c5f

* @default 3
*/
readonly connectionAttempts?: number;

"ConnectionTimeout": 10,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-cdk/packages/aws-cdk-lib/aws-cloudfront/lib/origin.ts

Lines 84 to 86 in db62c5f

* @default Duration.seconds(10)
*/
readonly connectionTimeout?: Duration;

"CustomOriginConfig": {
"HTTPPort": 80,
"HTTPSPort": 443,
"OriginKeepaliveTimeout": 5,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-cdk/packages/aws-cdk-lib/aws-cloudfront-origins/lib/vpc-origin.ts

Lines 36 to 38 in db62c5f

* @default Duration.seconds(5)
*/
readonly keepaliveTimeout?: cdk.Duration;

"OriginProtocolPolicy": "http-only",
"OriginReadTimeout": 30,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-cdk/packages/aws-cdk-lib/aws-cloudfront-origins/lib/vpc-origin.ts

Lines 25 to 27 in db62c5f

* @default Duration.seconds(30)
*/
readonly readTimeout?: cdk.Duration;

"OriginSSLProtocols": [
"TLSv1.2"
]
Expand All @@ -106,14 +87,15 @@
}
]
},
"Id": "origin1"
"Id": "integhttpsredirectsameregionredirectRedirectDistributionOrigin1609D30F4"
}
],
"PriceClass": "PriceClass_All",
"ViewerCertificate": {
"AcmCertificateArn": {
"Ref": "redirectRedirectCertificateD6C59F7F"
},
"MinimumProtocolVersion": "TLSv1.2_2021",
"SslSupportMethod": "sni-only"
}
}
Expand All @@ -122,12 +104,10 @@
"redirectRedirectAliasRecorde7728a9F2A656C": {
"Type": "AWS::Route53::RecordSet",
"Properties": {
"Name": "integ-same-region.example.com.",
"Type": "A",
"AliasTarget": {
"DNSName": {
"Fn::GetAtt": [
"redirectRedirectDistributionCFDistribution1A4C48E3",
"redirectRedirectDistribution5423F951",
"DomainName"
]
},
Expand All @@ -141,18 +121,18 @@
]
}
},
"HostedZoneId": "Z23ABC4XYZL05B"
"HostedZoneId": "Z23ABC4XYZL05B",
"Name": "integ-same-region.example.com.",
"Type": "A"
}
},
"redirectRedirectAliasRecordSixe7728a9391F03E": {
"Type": "AWS::Route53::RecordSet",
"Properties": {
"Name": "integ-same-region.example.com.",
"Type": "AAAA",
"AliasTarget": {
"DNSName": {
"Fn::GetAtt": [
"redirectRedirectDistributionCFDistribution1A4C48E3",
"redirectRedirectDistribution5423F951",
"DomainName"
]
},
Expand All @@ -166,7 +146,9 @@
]
}
},
"HostedZoneId": "Z23ABC4XYZL05B"
"HostedZoneId": "Z23ABC4XYZL05B",
"Name": "integ-same-region.example.com.",
"Type": "AAAA"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion ...g/test/aws-route53-patterns/test/integ.hosted-redirect-same-region.js.snapshot/integ.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ...ted-redirect-same-region.js.snapshot/integtestDefaultTestDeployAssert24D5C536.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

119 changes: 85 additions & 34 deletions ...est/aws-route53-patterns/test/integ.hosted-redirect-same-region.js.snapshot/manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading