-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(ec2): add support for IPAM allocation in Subnet configuration #34349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
ea5ae76
to
b01d66b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
0d57788
to
1d99898
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34296
Reason for this change
The L2 construct
Subnet
does not currently support IPAM CIDR allocation, but the L1 constructCfnSubnet
already does. This feature request proposes to make the L2 constructSubnet
IPAM aware, to provide a consistent ease of use similar to L1.Description of changes
This pull request enhances the L2
Subnet
construct to support IPAM allocation. The key changes include:SubnetProps
for IPAM-based CIDR allocation:ipv4IpamAllocation
: An optional object to configure IPv4 CIDR allocation from an IPAM pool. It typically accepts anipamPoolId
(string) and an optionalnetmaskLength
(number).ipv6IpamAllocation
: An optional object to configure IPv6 CIDR allocation from an IPAM pool. It typically accepts anipamPoolId
(string) and an optionalnetmaskLength
(number).Subnet
construct to handle these new properties:ipv4IpamAllocation
is specified (withipamPoolId
and optionallynetmaskLength
), the construct uses these details to set theIpv4IpamPoolId
andIpv4NetmaskLength
properties of the underlyingCfnSubnet
.ipv6IpamAllocation
is specified (withipamPoolId
and optionallynetmaskLength
), the construct uses these details to set theIpv6IpamPoolId
andIpv6NetmaskLength
properties of the underlyingCfnSubnet
.ipv4IpamAllocation
is specified along withcidrBlock
, or ifipv6IpamAllocation
is specified along withipv6CidrBlock
.ipv4IpamAllocation
oripv6IpamAllocation
is explicitly provided for the subnet.Describe any new or updated permissions being added
No new IAM permissions are added. Only existing EC2 permissions for allocating CIDRs from an IPAM pool are used.
Description of how you validated changes
cidrBlock
), were added to theSubnet
class tests.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license