feat(appconfig): deletion protection check for configuration profile #34418
+158
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p2
distinguished-contributor
aws-cdk-automation
added
the
pr/needs-community-review
mazyu36
approved these changes
May 12, 2025
aws-cdk-automation
added
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
scorbiere
reviewed
May 13, 2025
| * Deletion protection prevents a user from deleting a configuration profile if your application has called | ||
| * either `GetLatestConfiguration` or `GetConfiguration` for the configuration profile during the specified interval. | ||
| * | ||
| * @see https://docs.aws.amazon.com/appconfig/latest/userguide/delete-config-profile.html |
There was a problem hiding this comment.
For some reason, this link redirect to https://docs.aws.amazon.com/appconfig/latest/userguide/what-is-appconfig.html
What about one of these:
samson-keung
requested changes
May 13, 2025
| /** | ||
| * Configuration for deletion protection behavior. | ||
| */ | ||
| readonly deletionProtectionCheck?: DeletionProtectionCheck; |
There was a problem hiding this comment.
I think it is better to keep it private instead of exposing it for now until there is a use case to expose it. Keeping it private give us more flexibility in the future.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
None
Reason for this change
Cloudformation now supports for configuring deletion protection check for configuration profile in addition to environment.
https://docs.aws.amazon.com/appconfig/latest/userguide/deletion-protection.html
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-appconfig-configurationprofile.html#cfn-appconfig-configurationprofile-deletionprotectioncheck
Description of changes
deletionProtectionCheckto bothHostedConfigurationProfilePropsandSourcedConfigurationProfilePropsDescribe any new or updated permissions being added
None
Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license