-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(appconfig): deletion protection check for configuration profile #34418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Deletion protection prevents a user from deleting a configuration profile if your application has called | ||
* either `GetLatestConfiguration` or `GetConfiguration` for the configuration profile during the specified interval. | ||
* | ||
* @see https://docs.aws.amazon.com/appconfig/latest/userguide/delete-config-profile.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, this link redirect to https://docs.aws.amazon.com/appconfig/latest/userguide/what-is-appconfig.html
What about one of these:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've used the first one.
/** | ||
* Configuration for deletion protection behavior. | ||
*/ | ||
readonly deletionProtectionCheck?: DeletionProtectionCheck; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to keep it private instead of exposing it for now until there is a use case to expose it. Keeping it private give us more flexibility in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're absolutely right. I've removed deletionProtectionCheck
from IConfiguration
.
Pull request has been modified.
The CLI documentation suggests that a
However, this does not seem to be supported by Cloudformation. The PR looks good - thank you for contributing! |
Pull request has been modified.
@vishaalmehrishi Thank you for your review!! I've updated snapshot files to fix CI failure. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
Cloudformation now supports for configuring deletion protection check for configuration profile in addition to environment.
https://docs.aws.amazon.com/appconfig/latest/userguide/deletion-protection.html
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-appconfig-configurationprofile.html#cfn-appconfig-configurationprofile-deletionprotectioncheck
Description of changes
deletionProtectionCheck
to bothHostedConfigurationProfileProps
andSourcedConfigurationProfileProps
Describe any new or updated permissions being added
None
Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license