feat(appconfig): deletion protection check for configuration profile

[badmintoncryer]

Issue # (if applicable)

None

Reason for this change

Cloudformation now supports for configuring deletion protection check for configuration profile in addition to environment.

https://docs.aws.amazon.com/appconfig/latest/userguide/deletion-protection.html
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-appconfig-configurationprofile.html#cfn-appconfig-configurationprofile-deletionprotectioncheck

Description of changes

• Add deletionProtectionCheck to both HostedConfigurationProfileProps and SourcedConfigurationProfileProps

Describe any new or updated permissions being added

None

Description of how you validated changes

Add both unit and integ tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[scorbiere]

For some reason, this link redirect to https://docs.aws.amazon.com/appconfig/latest/userguide/what-is-appconfig.html
What about one of these:

• https://docs.aws.amazon.com/appconfig/latest/userguide/deletion-protection.html
• https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appconfig-configurationprofile.html#cfn-appconfig-configurationprofile-deletionprotectioncheck

[badmintoncryer]

Thanks! I've used the first one.

[samson-keung]

I think it is better to keep it private instead of exposing it for now until there is a use case to expose it. Keeping it private give us more flexibility in the future.

[badmintoncryer]

You're absolutely right. I've removed deletionProtectionCheck from IConfiguration.

Pull request has been modified.

[vishaalmehrishi]

The CLI documentation suggests that a ProtectionPeriodInMinutes config is also possible

You can increase the default interval to a maximum of 24 hours. Run the following command to specify a new interval.

aws appconfig update-account-settings --deletion-protection Enabled=true,ProtectionPeriodInMinutes=a number between 15 and 1440

However, this does not seem to be supported by Cloudformation.

The PR looks good - thank you for contributing!

Pull request has been modified.

[badmintoncryer]

@vishaalmehrishi Thank you for your review!! I've updated snapshot files to fix CI failure.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 393a118
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.