chore(enum-updater): support adding manual static enum mappings

[paulhcsun]

Issue # (if applicable)

Closes #.

Reason for this change

Manual changes to the static-enum-mapping.json would be overwritten the next time the workflow was run.

Description of changes

Add a new file manual-enum-mapping.json that allows maintainers to add manual mappings that will be used over any matching mapping that the script calculates.

Manual mappings should be added in the form:

{
    "serviceName": {
      "CdkEnumName": {
        "cdk_path": "path/to/cdkEnum",
        "sdk_service": "serviceName",
        "sdk_enum_name": "AwsEnumThatWeWantThisToMapTo",
        "match_percentage": 1.0,
        "manual": true
      }
    }
}

For example:

{
    "ec2": {
      "VpcEndpointIpAddressType": {
        "cdk_path": "aws-cdk/packages/aws-cdk-lib/aws-ec2/lib/vpc-endpoint.ts",
        "sdk_service": "ec2",
        "sdk_enum_name": "IpAddressType",
        "match_percentage": 1.0,
        "manual": true
      }
    }
}

Description of how you validated changes

Manual + unit testing

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[GavinZZ]

would this always be true? what if user accidentally add a entry to the manual-enum-mapping.json but add it as false?
how does manual get used?

[paulhcsun]

This should always be true but the value doesnt actually matter. When creating the static mapping, we only check if an entry for the specific enum exists by the enum name, if so, we just use the entry in the manual mapping instead which would include this manual field.

Basically the manual field just exists so that we know a static mapping was manually updated when we look at the entry in static-enum-mapping.json.

[scorbiere]

I would remove this field from the manual mapping file and let the code logic add it.

[GavinZZ]

what happen if you add it as false? would it still override?

[paulhcsun]

Yes, we check for the enum by its name, not by whether or not manual == true.

[scorbiere]

I guess the manual: true could be added here if it was not in the manual mapping file, right?

[paulhcsun]

I've updated it to add the manual: true here instead of having it specified in the manual overrides json file.

[scorbiere]

I would remove this field from the manual mapping file and let the code logic add it.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: ade53e1
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository