Skip to content

Conversation

@berviantoleo
Copy link
Contributor

@berviantoleo berviantoleo commented May 19, 2025

Reason for this change

Update the .NET requirements in documentation, previously only upgrading the templates.

#32894

Description of changes

  • Update documentation regarding the minimum .NET version

Describe any new or updated permissions being added

N/A

Description of how you validated changes

N/A

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels May 19, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 19, 2025 02:19
@berviantoleo
Copy link
Contributor Author

The current code build is using .NET 6.

image

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing

To prevent automatic closure:

  • Resume work on the PR
  • OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: "
  • OR request clarification by adding a comment containing 'Clarification Request' with a question e.x "Clarification Request: "

This PR will automatically close in 14 days if no action is taken.

@berviantoleo
Copy link
Contributor Author

berviantoleo commented Jun 10, 2025

Clarification Request:

The current template is generating .NET 8, however, the integration test uses .NET 6. I saw in jsii, seems we can't move to .NET 6 and/or 8 because it has some issues. Is it fine if those components have inconsistent versions?

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jun 10, 2025
@mrgrain
Copy link
Contributor

mrgrain commented Jun 10, 2025

Clarification Request:

The current template is generating .NET 8, however, the integration test uses .NET 6. I saw in jsii, seems we can't move to .NET 6 and/or 8 because it has some issues. Is it fine if those components have inconsistent versions?

Templates are a default. Requirements are, well, minimal requirements. I think it's fine for these to be inconsistent. But of course .NET 6 being EOL means it's a bit pointless to continue supporting. We can update the recommendation right now, but not the script before an update on the internal build runner.

Copy link
Contributor Author

@berviantoleo berviantoleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 10, 2025
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mergify
Copy link
Contributor

mergify bot commented Jun 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0149ff2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fc3b5f0 into aws:main Jun 11, 2025
20 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants