-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: update documentation for .NET requirement and scripts #34489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
|
Clarification Request: The current template is generating .NET 8, however, the integration test uses .NET 6. I saw in jsii, seems we can't move to .NET 6 and/or 8 because it has some issues. Is it fine if those components have inconsistent versions? |
Templates are a default. Requirements are, well, minimal requirements. I think it's fine for these to be inconsistent. But of course .NET 6 being EOL means it's a bit pointless to continue supporting. We can update the recommendation right now, but not the script before an update on the internal build runner. |
berviantoleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
mrgrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |

Reason for this change
Update the .NET requirements in documentation, previously only upgrading the templates.
#32894
Description of changes
Describe any new or updated permissions being added
N/A
Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license