chore(deps): bump stale fast-xml-parser resolution to 4.5.7 (GHSA-m7jm-9gc2-mpf2) - #38416
Open
AtsutoNakayama wants to merge 3 commits into
Open
chore(deps): bump stale fast-xml-parser resolution to 4.5.7 (GHSA-m7jm-9gc2-mpf2)#38416AtsutoNakayama wants to merge 3 commits into
AtsutoNakayama wants to merge 3 commits into
Conversation
AtsutoNakayama
temporarily deployed
to
automation
July 27, 2026 13:07 — with
GitHub Actions
Inactive
AtsutoNakayama
temporarily deployed
to
automation
July 27, 2026 13:07 — with
GitHub Actions
Inactive
AtsutoNakayama
temporarily deployed
to
automation
July 27, 2026 13:07 — with
GitHub Actions
Inactive
aws-cdk-automation
previously requested changes
Jul 27, 2026
Author
|
Exemption Request This PR doesn't add a unit test or an integration test because it doesn't change any CDK feature or behavior - it's a |
AtsutoNakayama
temporarily deployed
to
automation
July 27, 2026 13:11 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 27, 2026 13:11 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 27, 2026 13:11 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 27, 2026 13:34 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 27, 2026 13:34 — with
GitHub Actions
Inactive
1 task
AtsutoNakayama
temporarily deployed
to
automation
July 27, 2026 19:11 — with
GitHub Actions
Inactive
aws-cdk-automation
dismissed
their stale review
July 27, 2026 19:13
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AtsutoNakayama
temporarily deployed
to
automation
July 28, 2026 13:33 — with
GitHub Actions
Inactive
AtsutoNakayama
temporarily deployed
to
automation
July 28, 2026 13:34 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 28, 2026 14:06 — with
GitHub Actions
Inactive
AtsutoNakayama
temporarily deployed
to
automation
July 28, 2026 23:12 — with
GitHub Actions
Inactive
AtsutoNakayama
temporarily deployed
to
automation
July 28, 2026 23:12 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #38415.
Reason for this change
packages/@aws-cdk/custom-resource-handlersdepends on@aws-sdk/client-lambda@3.632.0(pinned since August 2024), which transitively pinsfast-xml-parserto the exact version4.4.1, vulnerable to GHSA-m7jm-9gc2-mpf2 (fixed in 4.5.4).Note: as clarified in #38415, this does not reach deployed Lambda assets -
packages/@aws-cdk/custom-resource-handlers/scripts/generate.jsmarks@aws-sdk/*asexternalin the esbuild config, so the AWS SDK (and thereforefast-xml-parser) is never bundled into the shipped handler code; at runtime these handlers use whatever AWS SDK the Lambda Node.js runtime provides, patched independently by AWS. This is purely a stale, noisyyarn.lockresolution that causes a cleanyarn auditon this repo to report a critical finding, and a two-year-old dependency pin - worth fixing on hygiene grounds, not because deployed user resources are affected.Description of changes
Added a
resolutionsentry in the rootpackage.jsonto forcefast-xml-parserto^4.5.4across the whole dependency tree (the existing dependent declares an exact pin4.4.1with no caret, so a plainyarn.lockversion bump is not sufficient here —resolutionsis required to override it). Ranyarn installto regenerateyarn.lock; the two previously separatefast-xml-parser@4.4.1/fast-xml-parser@^4.5.4lockfile entries were merged into a single resolved entry at4.5.7.Describe any new or updated permissions being added
None.
Description of how you validated changes
find . -path "*/node_modules/fast-xml-parser/package.json"confirms only one copy is installed, at4.5.7.npx lerna run build --scope=@aws-cdk/custom-resource-handlers --streambuilds successfully.npx jest triggers aws-synthetics(inpackages/@aws-cdk/custom-resource-handlers) — the existing unit tests for both affected handlers pass (24/24).yarn audit(Yarn Classic v1) does not evaluateresolutionsoverrides when reporting, so it will keep listing this advisory for thefast-xml-parser@4.4.1dependent even after the fix; the resolved/installed version inyarn.lockandnode_modulesis what actually matters, and that is confirmed patched.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license