fix(logs): use AccountPrincipal for drift prevention - #38420
Open
wasim-builds wants to merge 8 commits into
Open
fix(logs): use AccountPrincipal for drift prevention#38420wasim-builds wants to merge 8 commits into
wasim-builds wants to merge 8 commits into
Conversation
…emovalPolicy (Fixes aws#38327)
aws-cdk-automation
previously requested changes
Jul 27, 2026
Author
|
Exemption Request This is a minor, localized fix to swap |
aws-cdk-automation
temporarily deployed
to
automation
July 27, 2026 19:56 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 27, 2026 19:57 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 27, 2026 20:05 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
July 27, 2026 20:05 — with
GitHub Actions
Inactive
aws-cdk-automation
dismissed
their stale review
July 28, 2026 03:58
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Author
|
Hi! Following up on this — the AccountPrincipal fix for log-group drift prevention is small (+39/-7) and CI is passing. Would love a review when you have bandwidth! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #37797
What does this PR do?
Noticed a small bug causing false-positive CloudFormation drift alarms
because cross-account permissions were being written as raw account IDs
instead of ARNs. Swapped in
AccountPrincipalto force the canonical ARNformat.
Testing
Tested locally and verified the output format matches the canonical ARN
format expected by CloudFormation.
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license.