fix(s3-deployment): preserve custom log groups during deletion - #38446
fix(s3-deployment): preserve custom log groups during deletion#38446Hashim1999164 wants to merge 2 commits into
Conversation
Make the deployment handler depend on its custom log group so CloudFormation deletes the handler first and cannot recreate the group.
|
Updated the PR description to put the issue reference in the template's Issue section. This change already includes an integration snapshot update under |
|
Exemption Request: this fix already updates the integration snapshot at |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Issue # (if applicable)
Closes #35632.
Reason for this change
When a BucketDeployment uses a custom log group, make the singleton handler depend on that group. CloudFormation will then delete the handler before the log group, preventing late handler logs from recreating a group that the stack already deleted.
Description of change
Description of how you validated changes
npx jest aws-s3-deployment/test/bucket-deployment.test.ts --runInBand --coverage=false(71 tests passed)yarn integ --dry-run --update-on-failed test/aws-s3-deployment/test/integ.bucket-deployment-loggroup.js(passed)Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license