-
Notifications
You must be signed in to change notification settings - Fork 20
chore(CI): add a rebase gha for the mutations branch #1592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| - name: Create issue on rebase failure | ||
| if: steps.rebase.outputs.rebase_status == 'failed' | ||
| uses: actions/github-script@v6 | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| script: | | ||
| github.rest.issues.create({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| title: 'Rebase failed for mutations branch', | ||
| body: `The automatic rebase of the \`mutations\` branch failed due to conflicts.\n\n` + | ||
| `This happened after a push to the default branch by ${context.actor}.\n\n` + | ||
| `Please resolve the conflicts manually.` | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, do we create a new GHI for each commit that has conflicts or will it be added to an already cut GHI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no UUID or other reference in scope, it probably will create a new GHI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create a new one for each commit - highly overkill and will create lots of noise. We may opt for a different alert mechanism.
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| script: | | ||
| github.rest.issues.create({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking suggestions: We could also add a tag to the github issue
|
Question: Would we need to collapse from 3 PRs/branches to just one? |
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.