ci(rust): resolve aws-lc-sys versions, simplify duplicate aws-lc error message - #2366
Merged
Conversation
Replace the verbose failure spiel with a concise, actionable diff that prints the exact Cargo.toml line to change (before/after) and the version aws-lc-rs resolves to.
Refine the error message (repo-relative Cargo.toml path, exact line, resolving aws-lc-rs version). Bump aws-lc-rs to 1.18.0 and pin aws-lc-sys 0.44 / aws-lc-fips-sys 0.14.1 so only one AWS-LC compiles.
lucasmcdonald3
changed the title
Extend the duplicate-aws-lc gate to loop over both the DynamoDbEncryption and TestVectors Rust runtimes (matching the ESDK setup), and bump the TestVectors runtime to aws-lc-rs 1.18.0 / aws-lc-sys 0.44 / aws-lc-fips-sys 0.14.1 so only one AWS-LC compiles.
josecorella
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Replace verbose failure message slop with something useful.
ex. from actual DBESDK message log
Squash/merge commit message, if applicable:
ci(rust): resolve aws-lc-sys versions, simplify duplicate aws-lc error message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.